Skip to content

Fix GH-19070: setlocale($type, NULL) should not be deprecated #19071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-19070: setlocale($type, NULL) should not be deprecated #19071

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jul 8, 2025

This restores the old behaviour.

@nielsdos nielsdos requested review from kocsismate and bukka as code owners July 8, 2025 18:29
@nielsdos nielsdos linked an issue Jul 8, 2025 that may be closed by this pull request
setlocale($type, NULL) should not be deprecated #19070
Closed
remicollet
remicollet approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@remicollet remicollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, old behaviour restored

@remicollet
Copy link
Member

remicollet commented Jul 9, 2025 •
edited
Loading

An alternative way (to follow strictly doc) will be to accept int|string|null for 1st param, and only string for others, but this is probably a BC break.

So this PR seems the right fix.

Thanks for the quick fix

@nielsdos
Copy link
Member Author

An alternative way (to follow strictly doc) will be to accept int|string|null for 1st param, and only string for others, but this is probably a BC break.

Yes I think so as well, since we allowed [null] to behave the same way.
Thanks for checking.

@nielsdos nielsdos closed this in c4183fb Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remicollet remicollet remicollet approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
ABI break Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setlocale($type, NULL) should not be deprecated
2 participants
@nielsdos @remicollet